-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Update ACLs on file formats #2066
Conversation
According to juanfont#2024 (comment)
WalkthroughThe documentation for Access Control Lists (ACLs) has been revised to specify that ACLs must be written exclusively in huJSON format. This update eliminates the previous option of using YAML, clarifying the required format and ensuring that users are aware of the mandatory use of huJSON. The reference to test ACLs remains unchanged, but the emphasis on format has shifted from optional to mandatory. Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- docs/acls.md (1 hunks)
Additional comments not posted (1)
docs/acls.md (1)
46-46
: Verify the link to test ACLs.The documentation specifies that ACLs must be written in huJSON format, which is clear. However, ensure that the link to the test ACLs is correct and accessible.
Run the following script to verify the existence of the referenced directory:
Updated docs on ACLs according to the comment on YAML deprecation
By the way, the 'tests' link is broken and I couldn't find the files this link should mention. Any clues?
Summary by CodeRabbit