-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nan in datamatrix #4
Comments
I think I know what might be going on. Concatenating NaNs with non-NaNs results in NaNs (somewhat related (at about 3:40)). I'm working on a fix now. |
Maybe. |
@matarhaller What was the code you had for checking NaNs? I have the |
Got it 😅
👍 |
just to check if anything is nan: or you can do |
@juanshishido You're too speedy! |
Thanks! The shape of the matrix is now: I created a new notebook for this in a new branch. I think it might be better to just modify the original. What do you all think? |
What was happening was that some people did not fill out any essays. So their |
A question that stems (NLP joke) from this is, do we want to only use individuals who filled something out for all essays or are partial responses okay (of course, no responses aren't useful)? |
Good point. Since we have so much data, I'm okay with dropping people that didn't answer all the essays. |
Oh, okay! Sounds good. Happy to drop people who didn't answer and happy to convert to .py files. |
Great! We'll have to make sure do add that in. |
4b9355f fixes this. |
Decided to move the conversation of NaNs we were having in #7 here. @jnaras Everything ran and confirmed that With 5fd38b0, I rearranged the imports slightly (and removed the ones we were not using), removed the print statements in Thank you! |
Also, the pickled data is good 👍 |
So is master fully updated?
|
@matarhaller Yeah. It says jaya is 3 commits ahead of master, but that's because of how I updated master—fetched the jaya branch to get |
the datamatrix has nans in it, which breaks PCA. I'm not completely sure why they are there, but do you think it's reasonable to just replace nans with 0?
The text was updated successfully, but these errors were encountered: