CFG: Rewritten and well tested #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Attempt to generate a correct control flow graph with complex nested statements.
jubnzv
changed the title
…atements This commit adds unique identifiers for AST expression. This is required to distinguish expressions inside statements to link them with CFG nodes. After this commit I can build correct CFG nodes for expressions. But there are errors in building CFG for nested statements when them have multiple exit paths. Should be fixed.
This is required to parse JSON output with Python.
Required for pytest.
This also required changes in parser and AST to make case records keeps statements instead of expressions.
Stackoverflow problem in CFG creation routine was revealed, should be fixed.
This commit tries to fix stackoverflow with a large lists of statements. Appropriate test was added in test_core.py. This is not finished, because bbs_preds_ids CAN cause stackoverflow in some cases.
It was caused by control flow analysis when we traverse loops for control flow graph. Need to revisit after the update of CFG structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.