Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Close file stream after YAML serialization. #169

Merged
merged 2 commits into from
Jan 11, 2017
Merged

Close file stream after YAML serialization. #169

merged 2 commits into from
Jan 11, 2017

Conversation

djanjic
Copy link
Contributor

@djanjic djanjic commented Dec 1, 2016

After getting a file, metadata file stream is still open. This commit fixes that.

@djanjic
Copy link
Contributor Author

djanjic commented Dec 26, 2016

This pull request solves same problem

#61

@pickhardt
Copy link
Collaborator

Hi @perakojot,

Thanks for the pull request!

I can merge it in if you do two things first:

  1. You don't really have to do this, but if it's easy for you, can you add a space between the last parentheses and the last curly bracket? So it's File.open(File.join(obj_root,"metadata")) { |file| YAML::load(file) } If you don't want to go back to your code for such a small change, no worries, I can merge the PR and change it later myself.

  2. We have a contributor license agreement (CLA) based off of Google and Apache's CLA. If you would feel comfortable contributing to, say, Angular.js, you should feel comfortable with this CLA.

Go here to sign the CLA: https://docs.google.com/forms/d/e/1FAIpQLSeKKSKNNz5ji1fd5bbu5RaGFbhD45zEaCnAjzBZPpzOaXQsvQ/viewform

Thanks a lot, and if you do those I promise I'll get to merging it in!

@djanjic
Copy link
Contributor Author

djanjic commented Jan 11, 2017

  1. Done
  2. Done

@pickhardt pickhardt merged commit 69562e7 into jubos:master Jan 11, 2017
@pickhardt
Copy link
Collaborator

Thanks!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants