This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
s/max_keys/max-keys/ when parsing url query parameters #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to http://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketGET.html , the parameter is max-keys, not max_keys. You need the conversion to an int as well, since you're gonna use max_keys as in int in the rest of the code. But I'm no rubyist, so I don't know if that conversion is idiomatic.
eikevons
pushed a commit
to eikevons/fake-s3
that referenced
this pull request
Aug 26, 2015
Similar to jubos#64
uberjay
added a commit
to uberjay/fake-s3
that referenced
this pull request
Aug 3, 2016
|
You can just use "13".to_i to convert a string to an int. But thanks, I will merge this. |
|
Actually, why converting it to an int, then back to a string? That seems strange. I am removing that. |
|
Thanks for the PR but I'm going to have to change your commit. The tests are breaking and I need to fix them. |
|
OK, I have fixed the change now. The max-keys should work right. |
|
@pickhardt thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to http://docs.aws.amazon.com/AmazonS3/latest/API/RESTBucketGET.html , the parameter is max-keys, not max_keys.
You need the conversion to an int as well, since you're gonna use max_keys as an int in the rest of the code. But I'm no rubyist, so I don't know if that conversion is idiomatic.