Windows 10 & Windows 11

[krish777]

When all the below commands are executed in Windows 10 & Windows 11 got the same error.

Command 1. dictim -c '["John" "Manager"] ["Pauli" "Developer"] ["John" "->" "Pauli" "Test"]'

Error: Don't know how to create ISeq from: clojure. lang Symbol

Command 2. dictim -c '(["John" "Manager"] ["Pauli" "Developer"] ["John" "->" "Pauli" "test"])'

Error: Don't know how to create ISeq from: clojure.lang-Symbol

Command 3. dictim -c '(["John" "Manager"] ["Pauli" "Developer"] ["John" "->" "Pauli" "test"])' | d2 - >> out.svg

Error: Don't know how to create ISeq from: clojure.lang-Symbol

D2 file is generated, but when we open this file it contains same error Don't know how to create ISeq from: clojure.lang-Symbol

[judepayne]

I think this error is caused by the fact that you're not escaping double quotes in your strings. I will take a look.

In the meantime I suggest putting your content into a file and pulling it in with a <
This way you avoid the vagaries of terminal string handling, quoting and escaping

[judepayne]

What environment are you trying this on - Windows? all these work for me on Mac but I haven't tried Windows yet

[judepayne]

@eddielao
As you're on Windows, appreciate it you could try to replicate this and confirm it's an issue

[eddielao]

'["John"

Hi @judepayne , I am getting the same errors. My OS is Windows 10 pro.

[judepayne]

Thanks. I need to think about how to debug this

[eddielao]

Let me know if I can help. Thank you!

[judepayne]

Ok looked into how Windows command prompt handles strings and the above will not work. Not a dictim issue, but...
See this overview: https://ss64.com/nt/syntax-args.html
So, @eddielao instead of @krish777 's first example, can you please try:

dictim -c "[\"John\" \"Manager\"] [\"Pauli\" \"Developer\"] [\"John\" \"->\" \"Pauli\" \"Test\"]"

In other words, single quotes are not allowed and double quotes within double-quoted arguments have to be escaped.

The second example becomes

dictim -c "([\"John\" \"Manager\"] [\"Pauli\" \"Developer\"] [\"John\" \"->\" \"Pauli\" \"test\"])"

If those two work, then I suggest we close this issue and instead add a section here on the dictim wiki https://github.com/judepayne/dictim/wiki/Command-Line covering how to convert any of the example commands given to Windows, e.g. new section titled 'Converting commands to Windows Command Prompt'.

PR welcome on that one!

(please note that the dictim wiki is a separate project on GitHub, so will have to be forked etc etc..)

[eddielao]

Hi @judepayne , now we get 'The system cannot find the path specified.'

C:\Users\...\git>dictim -c "[\"John\" \"Manager\"] [\"Pauli\" \"Developer\"] [\"John\" \"->\" \"Pauli\" \"test\"]"
The system cannot find the path specified.

C:\Users\...\git>dictim -c "([\"John\" \"Manager\"] [\"Pauli\" \"Developer\"] [\"John\" \"->\" \"Pauli\" \"test\"])"
The system cannot find the path specified.

[judepayne]

hmm flying a bit blind here without a Windows setup myself.
However I think what is going on is that the now properly formatted argument (to compile) in double quotes is making Windows push that argument into std-in rather than treating it as an argument (the behaviour on Mac + Linux).
I made a tiny tweak to the 'handle-in' fn in the dictim.cmd ns, and put a bit of debug in there for now.
Once the latest dictim executable is finishing building for Windows here https://github.com/judepayne/dictim/releases (normally takes 10 minutes ish) please download it and re-run the command. Let me know what it says. Thanks!

[judepayne]

hmm - didn't build. Let's leave this one until I have a Windows dev environment. Windows cmd prompt seems to have some major behaviour differences to Mac/linux terminal which at the moment I cannot test

[eddielao]

hmm - didn't build. Let's leave this one until I have a Windows dev environment. Windows cmd prompt seems to have some major behaviour differences to Mac/linux terminal which at the moment I cannot test

Hi @judepayne, I went to the release page and saw the latest release was built 6 hours ago but version is still 0.8.7, which is the same version I downloaded on 9/1. Just wanted to double check. Thank you!

[judepayne]

Hi @eddielao the way it's set up, every push results in new runs of circleci (see inside the .circleci folder) for Mac and Linux and Appveyor (see appveyor.yml). As long as those scripts succeed, new versions of the Mac, linux and windows native command line tools are pushed to the releases page overwriting the previous versions. Breaking one of the principles of 12 factor apps I know! (but it's easier).
Should have a Windows dev environment within a day and can then get to the bottom of these differences

[eddielao]

Thank you, @judepayne ! I just wanted to make sure there is/is not a newer version that I should test. Thank you!

[judepayne]

@eddielao @krish777
Solved!
In Windows command prompt < and > are special characters and have to be escaped.

so

dictim -c "([\"john\" \"Manager\"] [\"pauli\" \"Developer\"] [\"john\" \"--\" \"pauli\"])"

works

but

dictim -c "([\"john\" \"Manager\"] [\"pauli\" \"Developer\"] [\"john\" \"->\" \"pauli\"])"

does not.

You have to escape using a caret ^ character, like so:

dictim -c "([\"john\" \"Manager\"] [\"pauli\" \"Developer\"] [\"john\" \"-^>\" \"pauli\"])"

I will update instructions on the wiki in the morning.

If the dictim string is in a file e.g. something like

dictim -c < my_dictim.edn

there's no need to escape.

So not a dictim error - a windows terminal knowledge thing as suspected, but worth noting on the wiki as it will catch anyone out.

[judepayne]

New 'Windows note' section added to Command line page of wiki + removed any debug added to try to trap the error previously (& pushed).

@krish777 @eddielao

I will close this issue now.

Fixed all the issues you've raised to me at this point. Do you want a new release? If you want to continue to test a bit more, no problem, the Releases page has all the latest, with-fixes, binaries for you to use (but still marked as v0.8.7).

[eddielao]

Hi @judepayne, yes to a minor release?

[judepayne]

I will do that. I will squeeze in a resolution for issue #12 as well

[judepayne]

@krish777 the latest build of 0.8.7 has all the bug fixes and also changes how comments are represented

[judepayne]

@eddielao also pushed as 0.8.8 release. Code in the binaries is the same!