Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed line endings with normalization. #11

Merged
merged 2 commits into from
Sep 1, 2024

Conversation

eddielao
Copy link
Contributor

Test result for Windows 11.

Eddie@LZXTH1 MINGW64 ~/OneDrive/Dev/git/dictim (fix-line-ends)
$ clj -X:test

Running tests in #{"test"}

Testing dictim.d2.compile-test

Testing dictim.d2.parse-test

Testing dictim.flat-test

Testing dictim.graphspec-test

Testing dictim.json-test

Testing dictim.template-test

Ran 83 tests containing 361 assertions.
0 failures, 0 errors.

Eddie@LZXTH1 MINGW64 ~/OneDrive/Dev/git/dictim (fix-line-ends)

@judepayne
Copy link
Owner

I will accept this PR - thank you.
One change to make. Can you make the new function private to the namespace please?

@eddielao
Copy link
Contributor Author

eddielao commented Sep 1, 2024

I will accept this PR - thank you. One change to make. Can you make the new function private to the namespace please?

Hi @judepayne , thank you for the suggestion! Change made and reran the test.

$ git commit -m "Made normalize-line-endings function private."
[fix-line-ends af109e9] Made normalize-line-endings function private.
1 file changed, 1 insertion(+), 1 deletion(-)

$ clj -X:test

Running tests in #{"test"}

Testing dictim.d2.compile-test

Testing dictim.d2.parse-test

Testing dictim.flat-test

Testing dictim.graphspec-test

Testing dictim.json-test

Testing dictim.template-test

Ran 83 tests containing 361 assertions.
0 failures, 0 errors.

@judepayne judepayne merged commit acfd652 into judepayne:main Sep 1, 2024
1 check passed
@judepayne
Copy link
Owner

Thankyou! Merged and re-pushed

@judepayne
Copy link
Owner

BTW, please see my comment to you here: #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants