Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #90 Add minimum rich version to requirements.txt #91

Merged
merged 4 commits into from
Jul 4, 2022

Conversation

acaloiaro
Copy link
Contributor

This fixes #90 by declaring a minimum rich version

@juftin
Copy link
Owner

juftin commented Jul 3, 2022

Oh, thank you! If you can increment the _version.py file this is good to go!

@acaloiaro
Copy link
Contributor Author

@juftin done! Thanks for putting together a great little CLI


For versioning, I highly recommend using python semantic release in a Github action to automatically bump versions on merge to main.

@juftin
Copy link
Owner

juftin commented Jul 3, 2022

I'll get a look at this a bit later today to fix some of the CI/CD issues. Thank you for the contribution @acaloiaro !

@juftin
Copy link
Owner

juftin commented Jul 3, 2022

Alright @acaloiaro this is my bad - the failing CI/CD job is the Documentation generation and that shouldn't be running on Pull Requests anyways. If you merge the changes from my bugfix/docs_generation_triggers branch everything will be good to go. See acaloiaro#1

@acaloiaro
Copy link
Contributor Author

@juftin 👍 All set

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breakage when rich version < 10.0.0
2 participants