Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent anchoring in regex #141

Open
romainmenke opened this issue Feb 29, 2024 · 1 comment
Open

Inconsistent anchoring in regex #141

romainmenke opened this issue Feb 29, 2024 · 1 comment

Comments

@romainmenke
Copy link

resize-observer/src/algorithms/calculateBoxSize.ts

Line 17 in 05c6ede

const verticalRegexp = /^tb|vertical/;

Was it intentional that only tb is anchored and that vertical is not, or should the regex be : /^tb|^vertical/?
@TremayneChrist
Copy link
Member

This is not intentional. Good find.

@romainmenke romainmenke mentioned this issue Jul 1, 2024
Merged
romainmenke added a commit to mrhenry/polyfill-library that referenced this issue Jul 1, 2024
@romainmenke
fix resize observer (#48)
cdd9584 
see : juggle/resize-observer#141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TremayneChrist @romainmenke