Pin Tensorflow and Keras version numbers in README instructions #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code in the README for creating the conda environment are not pinned to any specific version of Tensorflow and Keras, even though descriptions in the text above and below stress the importance of only using specific compatifble versions. I think it would be a smoother experience for new users if those versions were also pinned explicitly with conda.
Right now if you create a Python 3.6 conda environment and conda install tensorflow-gpu and keras into it unpinned (i.e. like the current code snippet in the readme) then you get Tensorflow version 2, which is incompatible with noise2void.
Note: it also seems like there might be a small typo in the sentence about the keras version number, should this read "... version of keras be 2.2.4 or 2.2.5" instead of "... version of keras be 2.24 or 2.2.5"?
Previous related issues: #39