Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin Tensorflow and Keras version numbers in README instructions #54

Merged
merged 2 commits into from
Nov 7, 2019

Conversation

GenevieveBuckley
Copy link
Contributor

The code in the README for creating the conda environment are not pinned to any specific version of Tensorflow and Keras, even though descriptions in the text above and below stress the importance of only using specific compatifble versions. I think it would be a smoother experience for new users if those versions were also pinned explicitly with conda.

Right now if you create a Python 3.6 conda environment and conda install tensorflow-gpu and keras into it unpinned (i.e. like the current code snippet in the readme) then you get Tensorflow version 2, which is incompatible with noise2void.

Note: it also seems like there might be a small typo in the sentence about the keras version number, should this read "... version of keras be 2.2.4 or 2.2.5" instead of "... version of keras be 2.24 or 2.2.5"?

Previous related issues: #39

@tibuch tibuch merged commit d47f9a8 into juglab:master Nov 7, 2019
@tibuch
Copy link
Collaborator

tibuch commented Nov 7, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants