Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add twine check to tox #137

Open
tabebqena opened this issue Aug 2, 2022 · 4 comments
Open

Add twine check to tox #137

tabebqena opened this issue Aug 2, 2022 · 4 comments
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed

Comments

@tabebqena
Copy link
Contributor

If it possible, It will has benifit to add the twine check in tox:

`python -m build --sdist --wheel .
 python -m twine check dist/*`

That commands run by the github action will-it-build.

`
@jugmac00
Copy link
Owner

Indeed - we could add a check. Currently I am the only one who creates releases, so I think it is not a very urgent issue.

@jugmac00
Copy link
Owner

jugmac00 commented Oct 1, 2022

@tabebqena Would you like to provide a pull request?

@jugmac00 jugmac00 added help wanted Extra attention is needed good first issue Good for newcomers hacktoberfest labels Oct 1, 2022
@tabebqena
Copy link
Contributor Author

tabebqena commented Oct 7, 2022

Currently I am the only one who creates releases, so I think it is not a very urgent issue.

In one trial of my pull request, the tox ran successfully in my local code and failed after pushing it.

@tabebqena Would you like to provide a pull request?

Sorry, I think that I have no experience with it.

@jugmac00
Copy link
Owner

@tabebqena
I thought a bit about it, and I do not think it is worth it.

My will-it-build GitHub Action is more like a toy example as I wanted to try out how to create a GitHub Action myself.

When running tox we already build the package, so I

jugmac00 added a commit that referenced this issue Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers hacktoberfest help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants