Enhance generic aliases with lifetimes support #458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR will add support for aliases with lifetimes. As demonstrated now
the lifetime variable can be declared or omitted from left side of
equals (=) mark. The lifetime at right side of the equals mark will be
used as a lifetime for generated Rust type alias.
```rust
#[aliases(Paginated1<'b> = Paginated<'b, String>, Paginated2 = Paginated<'b, Value>)]
struct Paginated<'r, TResult> {
pub total: usize,
pub data: Vec<TResult>,
pub next: Option<&'r str>,
pub prev: Option<&'r str>,
}
```
There is still one limitation with `'static` lifetimes. E.g if one would
define alias as `Paginated3 = Paginated<'static, Value>` this would
cause a compile error. Normally this would be allowed syntax in Rust
code.
There is a need to deprecate this alias functionality in future in favor
of adding a generic solution for Rust type aliases in general.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for aliases with lifetimes. As demonstrated now the lifetime variable can be declared or omitted from left side of equals (=) mark. The lifetime at right side of the equals mark will be used as a lifetime for generated Rust type alias.
There is still one limitation with
'staticlifetimes. E.g if one would define alias asPaginated3 = Paginated<'static, Value>this would cause a compile error. Normally this would be allowed syntax in Rust code.There is a need to deprecate this alias functionality in future in favor of adding a generic solution for Rust type aliases in general.
Resolves #427