Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix: use map() instead of unwrap() #536

Merged
merged 1 commit into from
Mar 22, 2023
Merged

bugfix: use map() instead of unwrap() #536

merged 1 commit into from
Mar 22, 2023

Conversation

Narayanbhat166
Copy link
Contributor

Closes #535

This PR replaces few of the unwraps() used in the codebase to map() and then call unwrap_or() on those fields to provide a default value. This change is required because when using rustfmt::skip get_ident() function returns None, calling unwrap() on this value results in panic.

juhaku
juhaku approved these changes Mar 22, 2023
View reviewed changes
Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for the patch 🎉

@juhaku juhaku merged commit 2deda0a into juhaku:master Mar 22, 2023
@Narayanbhat166 Narayanbhat166 mentioned this pull request Mar 28, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juhaku juhaku juhaku approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unable to use rustfmt::skip attribute with ToSchema
2 participants
@Narayanbhat166 @juhaku