Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix syntax: change pub(super) enum to pub enum #926

Merged
merged 1 commit into from
May 15, 2024

Conversation

cuiihaoo
Copy link
Contributor

@cuiihaoo cuiihaoo commented May 15, 2024

When I was using utoipa, I found a syntax error that prevented me from completing the cargo build. pub(super) enum str will cause the function parse_next_literal_str_or_include_str error on L.2913 in this file. As shown in the figure below:
image

Therefore, the deletion (super) is consistent with the pub enum Value on L.2856 in this file.
image

Resolves #908 Resolves #918

@juhaku
Copy link
Owner

juhaku commented May 15, 2024

Thanks for fixing this, That is weird, I am not able to reproduce this issue, but better to change the syntax here. What Rust version you are using?

@juhaku juhaku merged commit 7563a72 into juhaku:master May 15, 2024
7 checks passed
@cuiihaoo
Copy link
Contributor Author

Thanks for fixing this, That is weird, I am not able to reproduce this issue, but better to change the syntax here. What Rust version you are using?

cargo 1.73.0 (9c4383fb5 2023-08-26)
rustc 1.73.0 (cc66ad468 2023-10-03)

@juhaku
Copy link
Owner

juhaku commented May 15, 2024

Right, seems like an issue with the Rust level. The minimum will change in master to 1.75 from now on.

juhaku pushed a commit that referenced this pull request Oct 7, 2024
Co-authored-by: cuihao <cuiiihaoo@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't leak crate-private type error utoipa-gen-4.3.0 leaks crate-private type
2 participants