Fix compile error propagation #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juhaku
force-pushed
the
fix-compile-error-path-params
branch
from
23993e1
to
e0ad0de
Compare
Fix compile error propagation via comprehensive use of `ToTokensDiagnostics` trait. `ToTokensDiagnostics` was introduced in PR #920 to allow error propagation up in the call stack for error reporting. However this initial implementation was too limited which resulted invalid compile errors in case of error. This implementation aims to fix the shortcomings of the initial implementation.
juhaku
force-pushed
the
fix-compile-error-path-params
branch
from
e0ad0de
to
87b177d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix compile error propagation via comprehensive use of
ToTokensDiagnosticstrait.ToTokensDiagnosticswas introduced in PR #920 to allow error propagation up in the call stack for error reporting. However this initial implementation was too limited which resulted invalid compile errors in case of error. This implementation aims to fix the shortcomings of the initial implementation.Fixes #927