Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CARGO_HTTP_CAINFO CA file in build script if present #935

Merged
merged 1 commit into from
May 21, 2024

Conversation

ranger-ross
Copy link
Contributor

@ranger-ross ranger-ross commented May 21, 2024

This PR adds support for using the CARGO_HTTP_CAINFO cargo option if its present.
See #934 for more details.

CARGO_HTTP_CAINFO is optional and the behavior will not change if it is not present.
If it is present and we fail to read/parse the file, we just skip adding it and attempt to download the file without setting a custom CA.

Resolves #934

Copy link
Owner

@juhaku juhaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the PR

@juhaku juhaku merged commit 335407b into juhaku:master May 21, 2024
7 checks passed
@juhaku juhaku linked an issue May 21, 2024 that may be closed by this pull request
@ranger-ross ranger-ross deleted the support-custom-ca branch May 22, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Released
Development

Successfully merging this pull request may close these issues.

Build script should respect the Cargo http.cainfo
2 participants