Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace test API calls with mocks #6

Closed
juhalehtonen opened this issue Oct 1, 2017 · 3 comments
Closed

Replace test API calls with mocks #6

juhalehtonen opened this issue Oct 1, 2017 · 3 comments
Labels
Hacktoberfest

Comments

@juhalehtonen
Copy link
Owner

Currently the tests are calling the real API, which can result in unexpected behaviour and inconsistent results (timeouts at any point in time can make the build fail).

This could be achieved with something like https://github.com/jjh42/mock
@ppsmirnov
Copy link
Contributor

Can I take this one?

@juhalehtonen
Copy link
Owner Author

Hey, absolutely! Did you plan on using the mock library I linked in the description, or do you have ideas for something else?

@ppsmirnov
Copy link
Contributor

I think, I'll go with the one you linked.

@ppsmirnov ppsmirnov mentioned this issue Oct 1, 2017
Merged
juhalehtonen added a commit that referenced this issue Oct 2, 2017
@juhalehtonen
Merge pull request #7 from ppsmirnov/feature/test-mocks
ff7f5aa 
Add mocks for HTTP requests, closing issue #6 .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Hacktoberfest
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ppsmirnov @juhalehtonen