Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded kojihub endpoint #1

Closed
TristanCacqueray opened this issue Jul 14, 2020 · 3 comments · Fixed by #3
Closed

Hardcoded kojihub endpoint #1

TristanCacqueray opened this issue Jul 14, 2020 · 3 comments · Fixed by #3

Comments

@TristanCacqueray
Copy link
Contributor

The hub string is hard coded in Fedora.Koji.Api, would it be possible to update the api to support custom endpoint?
@juhp
Copy link
Owner

juhp commented Jul 17, 2020

Yes, was thinking the same thing recently.
Not quite sure why I thought this was okay ;-) probably just being lazy initially.

@TristanCacqueray
Copy link
Contributor Author

I suppose using unsafePerformIO getEnv is not an option... How about we change all the signature to include the url as the first argument?

@TristanCacqueray TristanCacqueray mentioned this issue Jul 18, 2020
Merged
@juhp juhp closed this as completed in #3 Jul 19, 2020
@juhp
Copy link
Owner

juhp commented Jul 19, 2020 •
edited
Loading

Yes, I like this simple solution, thanks.

I am also doing the same in pagure-hs and pdc-hs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Update APi functions to set the kojihub url TristanCacqueray/koji-hs
2 participants
@juhp @TristanCacqueray