Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update APi functions to set the kojihub url #3

Merged
merged 3 commits into from
Jul 19, 2020

Conversation

TristanCacqueray
Copy link
Contributor

@TristanCacqueray TristanCacqueray commented Jul 18, 2020

Fixes: #1

@juhp
Copy link
Owner

juhp commented Jul 19, 2020

LGTM, thank you 👍

Sorry needs a rebase after I merged your other PR :-)

This change was mostly generated using retrie:
  retrie --adhoc 'forall arg. koji arg = koji hubUrl arg'
This change was generated using:
for api in $(grep "^[a-z].* = koji hubUrl" API.hs | awk '{ print $1 }'); do
  sed -e "s/^$api ::/$api :: String ->/" \
      -e "s/^$api \([^=]*\)= koji/$api hubUrl \1= koji/" \
      -i API.hs
done
@juhp
Copy link
Owner

juhp commented Jul 19, 2020

Thank you very much, merged!

@TristanCacqueray
Copy link
Contributor Author

That is great, thank you for the prompt review!

@TristanCacqueray TristanCacqueray changed the title Update koji call site to include the kojiHubUrl Update APi functions to set the kojihub url Jul 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hardcoded kojihub endpoint
2 participants