Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migration to latest test framework versions #164

Closed
3 tasks done
bkimminich opened this issue Jul 27, 2016 · 10 comments
Closed
3 tasks done

Migration to latest test framework versions #164

bkimminich opened this issue Jul 27, 2016 · 10 comments
Assignees
@bkimminich
Labels
testing
Milestone
TechStack Update

Comments

@bkimminich
Copy link
Member

bkimminich commented Jul 27, 2016 •
edited

Migrate all unit and integration tests to

  • jasmine 2.x
  • karma-jasmine 1.x
  • frisby 2.x
@bkimminich bkimminich added this to the TechStack Overhaul milestone Sep 5, 2016
bkimminich added a commit that referenced this issue Oct 10, 2016
@bkimminich
Migration to Jasmine 2, see #164
f200dbf 
(Most server tests not yet migrated!)
@bkimminich
Copy link
Member Author

bkimminich commented Oct 10, 2016 •
edited

Reverted attempted migration due to high effort and unfinished implementation of frisby v2. Also jasmine-node still has no official release of their v2.

Right now stability of v1 seems to outweigh potential benefits of v2. Migration is postponed until at least finaly v2 release of frisby.

(depends on vlucas/frisby#316)

Migrating the client-side unit tests (karma, jasmine) and the e2e suite (protractor, jasmine) to latest did not cause any immediate problems or extra efforts.

@bkimminich bkimminich mentioned this issue Nov 27, 2016
Closed
@bkimminich
Copy link
Member Author

bkimminich commented Jul 11, 2017 •
edited

Side effect: Current workaround for stryker-mutator using coverageAnalysis: 'all' instead of 'perTest' can only be removed by migrating to karma-jasmine 1.x. See https://gitter.im/stryker-mutator/stryker?at=596475200de4d2545e15e275 Fixed by migrating to Jasmine 2!

@bkimminich bkimminich self-assigned this Jul 11, 2017
@bkimminich
Copy link
Member Author

Frisby v2 is in Alpha now, so it could actually be tried out at least: https://github.com/vlucas/frisby/tree/2.0.0-alpha.3

@bkimminich
Copy link
Member Author

frisby migration currently blocked by vlucas/frisby#364

@bkimminich bkimminich added ready and removed blocked labels Jul 25, 2017
@bkimminich
Copy link
Member Author

vlucas/frisby#364 has been resolved, unblocking this issue.

@bkimminich bkimminich added blocked and removed ready labels Jul 26, 2017
@bkimminich
Copy link
Member Author

Back into blocked state from another issue in frisby v2: vlucas/frisby#365

@bkimminich
Copy link
Member Author

Unblocked as acceptable workaround exists: vlucas/frisby#365 (comment)

@bkimminich
Copy link
Member Author

Small leftover frisby2 issues remain as well as jasmine-node still using Jasmine 1.3 for running frisby.

@bkimminich
Copy link
Member Author

Migrated frisby2 tests to run with Jest instead of outdated jasmine-node.

@lock
Copy link

lock bot commented Nov 4, 2019

This thread has been automatically locked because it has not had recent activity after it was closed. 🔒 Please open a new issue for regressions or related bugs.

@lock lock bot locked and limited conversation to collaborators Nov 4, 2019
crispy-peppers pushed a commit to crispy-peppers/juice-shop that referenced this issue Nov 12, 2019
@ColdHeat
Closes juice-shop#164
9fc83b6 
Adds support for unicode keys
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bkimminich bkimminich

Labels
testing
Projects
None yet
Milestone
TechStack Update
Development

No branches or pull requests
1 participant
@bkimminich