-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix team name validation in UI #174
Conversation
Also note that |
1209429
to
779013e
Compare
Although it _should_ be valid to have an unescaped `-`, at least Google Chrome and Firefox complain about an "Invalid character in character class" and completely skip validation, leading to confusion as to why team creation fails. Also fixed the validation message to state the minimum number of characters and applied red text color on invalid input.
72e0737
to
87d64f6
Compare
@stuebingerb you probably mean the vulns from the balancer backend |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh nice, thank you yeah i guess that was slightly wrong.
will probably tweak the coloring a bit :)
Feel free, mine was mostly a proof-of-concept 😉 |
Although it should be valid to have an unescaped
-
, at least Google Chrome and Firefox complain about an "Invalid character in character class" and completely skip validation, leading to confusion as to why team creation fails.Also fixed the validation message to state the minimum number of characters and applied red text color on invalid input.