Fix KeyError when 'current' is missing #183
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed fix for an error I've seen occasionally in our test runs:
It looks like this can occur when calling
sentry.wait()
immediately after removing a unit. This is exactly what our failing test is doing: https://github.com/juju-solutions/bundle-canonical-kubernetes/blob/master/tests/20-charm-validation.py#L169-L171The root cause seems to be that Juju, sometimes, does not include the
current
key withinjuju-status
(which is normalized toagent-status
in amulet). See this output that occurred during model destruction, where unit etcd/2 is missing thecurrent
key.