Pass channel back when resolving. #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following changes updates the revision getter to now pass back the channel. Updating any code to ensure that we rename any old naming to the new one. Unfortunately we have to request the channel before we can check the equality, previously we checked just the channels. This became a problem when the existing application had been resolved even if the channel was empty, yet the bundle was still shown to be empty. Effectively preventing the deployment of bundles with empty channels. The new unit tests ensure we get the correct error message based on the content of the model and the bundle.
|
|
Merged
jujubot
added a commit
that referenced
this pull request
Feb 24, 2021
#93 Merge conflict for changes_test.go - merge was resolved easily. e3037fe (upstream/v4, origin/v4, v4) Merge pull request #92 from SimonRichardson/upgrade-charm-channel a62d69d Merge pull request #91 from SimonRichardson/upgrade-charm-channel 889cd22 Merge pull request #90 from SimonRichardson/upgrade-charm-channel 350614c Merge pull request #89 from SimonRichardson/application-channel
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following changes updates the revision getter to now pass back the
channel. Updating any code to ensure that we rename any old naming to
the new one.
Unfortunately we have to request the channel before we can check the
equality, previously we checked just the channels. This became a problem
when the existing application had been resolved even if the channel was
empty, yet the bundle was still shown to be empty. Effectively
preventing the deployment of bundles with empty channels. The new unit
tests ensure we get the correct error message based on the content of
the model and the bundle.