contrib/ceph: Add BlueStore Compression support #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnordahl
force-pushed
the
ceph-bluestore-compression
branch
5 times, most recently
from
8950dcf
to
5943c6a
Compare
fnordahl
force-pushed
the
ceph-bluestore-compression
branch
3 times, most recently
from
656435d
to
6eb9628
Compare
fnordahl
changed the title
fnordahl
commented
Jul 29, 2020
Comment on lines
+587
to
+663
| call(['ceph', '--id', 'admin', 'osd', 'pool', | ||
| 'set', 'test', 'target_size_ratio', '1.0']), |
There was a problem hiding this comment.
Note that this was called after creation of erasure coded pools before the change too, but the order has now changed which means we need to include it in the check.
fnordahl
force-pushed
the
ceph-bluestore-compression
branch
3 times, most recently
from
e97e722
to
143f172
Compare
fnordahl
force-pushed
the
ceph-bluestore-compression
branch
5 times, most recently
from
5bf7bc3
to
86cc9b0
Compare
fnordahl
changed the title
fnordahl
force-pushed
the
ceph-bluestore-compression
branch
3 times, most recently
from
1cc7663
to
a97b448
Compare
fnordahl
changed the base branch from
master
to
tidy-long-lines-docstring-contrib-ceph
fnordahl
changed the base branch from
tidy-long-lines-docstring-contrib-ceph
to
master
Deprecate the current ``Pool`` class and replace it with a ``BasePool`` class to keep compatibility with any external consumers. The new class moves the create and post-create steps into the private ``_create`` and ``_post_create`` methods that the pool type specific children override. This allows for common post-creation steps to be shared.
Adds missing support for specifying group namespace for Erasure Coded pools. Adds missing test for raising an error when both 'pg_num' and 'weight' is specified for Replicated pools.
The `ceph osd pool set {pool-name}` command line tool takes
exactly one key value pair [0]. Update the helper and
documentation to reflect this and add unit tests.
0: https://docs.ceph.com/docs/master/rados/operations/pools/#set-pool-values
Some pool properties should be allowed adjusted after a pool is created. The Pool quota property is already handled ad-hoc in the `charms.ceph` broker handling code, let's bring it over here along with the handling of the compression properties.
Validate op before performing create and update operations. Instantiate pool and call the validation method on call to CephBrokerRq add_op_* methods. This way we will have validation of data both on data entry from consuming charm side and after deserializing on the executing ceph charm side.
fnordahl
force-pushed
the
ceph-bluestore-compression
branch
from
a97b448
to
301d5bb
Compare
javacruft
approved these changes
Aug 7, 2020
openstack-mirroring
pushed a commit
to openstack/charms.ceph
that referenced
this pull request
Aug 27, 2020
Use the Pool classes ability to initialize themselves from op. Some pool properties should be allowed adjusted after a pool is created. The Pool quota property is already handled ad-hoc in the `charms.ceph` broker handling code, let's bring it over to the pool objects along with the handling of the compression properties. Move some missing unit tests here from ceph-mon charm. Merge after juju/charm-helpers#497 Change-Id: Ibec4e3221387199adbc1a920e130975d7b25343c
openstack-mirroring
pushed a commit
to openstack/openstack
that referenced
this pull request
Aug 27, 2020
* Update charms.ceph from branch 'master'
- Use common pool create/update handling code
Use the Pool classes ability to initialize themselves from op.
Some pool properties should be allowed adjusted after a pool is
created.
The Pool quota property is already handled ad-hoc in the
`charms.ceph` broker handling code, let's bring it over to the
pool objects along with the handling of the compression properties.
Move some missing unit tests here from ceph-mon charm.
Merge after juju/charm-helpers#497
Change-Id: Ibec4e3221387199adbc1a920e130975d7b25343c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please review this commit by commit, and please DO NOT squash on merge!