Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base layer doesn't have upgrade-charm hook #10

Closed
merlijn-sebrechts opened this issue Oct 9, 2015 · 2 comments
Closed

Base layer doesn't have upgrade-charm hook #10

merlijn-sebrechts opened this issue Oct 9, 2015 · 2 comments
Milestone

Comments

@merlijn-sebrechts
Copy link
Contributor

I see the base layer doesn't include the upgrade-charm hook. What is the reason behind this? I think it should be included in the base layer since the idea is that every Charm will have one.

@johnsca
Copy link
Contributor

johnsca commented Oct 14, 2015

I agree. You could, of course, create a regular upgrade-charm hook, but I think it would be useful to have it use the reactive pattern if only to easily enable multiple layers to perform actions on upgrade.

However, the basic layer isn't technically part of charm-tools, so I've re-opened this issue on the (new) basic layer repo mentioned above.

@johnsca johnsca closed this as completed Oct 14, 2015
@merlijn-sebrechts
Copy link
Contributor Author

Thanks!

@marcoceppi marcoceppi added this to the 1.8.0 milestone Oct 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants