Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the build #219

Merged
merged 1 commit into from
Nov 11, 2020
Merged

fix the build #219

merged 1 commit into from
Nov 11, 2020

Conversation

chenrui333
Copy link
Contributor

Fix the build issue when I was trying to keep the formula to the latest

# github.com/docker/docker/pkg/term
/Users/rchen/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/docker/docker@v17.12.0-ce-rc1.0.20200916142827-bd33bbf0497b+incompatible/pkg/term/tc.go:13:28: undefined: unix.SYS_IOCTL
/Users/rchen/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/docker/docker@v17.12.0-ce-rc1.0.20200916142827-bd33bbf0497b+incompatible/pkg/term/tc.go:18:28: undefined: unix.SYS_IOCTL
/Users/rchen/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/docker/docker@v17.12.0-ce-rc1.0.20200916142827-bd33bbf0497b+incompatible/pkg/term/termios_bsd.go:24:31: undefined: unix.SYS_IOCTL
/Users/rchen/Library/Caches/Homebrew/go_mod_cache/pkg/mod/github.com/docker/docker@v17.12.0-ce-rc1.0.20200916142827-bd33bbf0497b+incompatible/pkg/term/termios_bsd.go:37:31: undefined: unix.SYS_IOCTL

mhilton
mhilton approved these changes Nov 11, 2020
View reviewed changes
Copy link
Contributor

@mhilton mhilton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhilton mhilton merged commit 1226bc9 into juju:master Nov 11, 2020
@chenrui333 chenrui333 mentioned this pull request Nov 11, 2020
Closed
@chenrui333 chenrui333 deleted the patch-1 branch November 11, 2020 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhilton mhilton mhilton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @mhilton