[JUJU-3293] Hardware Info should be optional #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately, HardwareInfo isn't always available for every MAAS version. The prior PR[1] expected that hardware_info was available. The fix is simple, just make it optional when attempting to validate it with the schema coercing. Additionally, I've added a few more tests to ensure that we're testing various scenarios of hardware_info being omitted. Lastly, it felt like there was a missing check for TestReadMachines for validating the hardware info for a given machine response. This should fix[2] in Juju. 1. juju#96 2. https://bugs.launchpad.net/juju/+bug/2009064
|
/merge |
SimonRichardson
added a commit
to SimonRichardson/juju
that referenced
this pull request
Mar 17, 2023
The following brings in the gomaasapi dependency that allows the hardware info attribute to be optional. See the gomaasapi dependency for more information[1]. 1. juju/gomaasapi#99
1 task
jujubot
added a commit
to juju/juju
that referenced
this pull request
Mar 18, 2023
#15312 The following brings in the gomaasapi dependency that allows the hardware info attribute to be optional. See the gomaasapi dependency for more information[1]. 1. juju/gomaasapi#99 ## Checklist - [x] Code style: imports ordered, good names, simple structure, etc ## QA steps ```sh $ juju bootstrap maas test --build-agent $ juju add-machine $ juju deploy ubuntu ``` ## Bug reference https://bugs.launchpad.net/juju/+bug/2009064
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, HardwareInfo isn't always available for every MAAS version. The prior PR[1] expected that hardware_info was available. The fix is simple, just make it optional when attempting to validate it with the schema coercing.
Additionally, I've added a few more tests to ensure that we're testing various scenarios of hardware_info being omitted. Lastly, it felt like there was a missing check for TestReadMachines for validating the hardware info for a given machine response.
This should fix[2] in Juju.