Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use set_verbosity abstraction instead of set #15470

Merged
merged 1 commit into from
Apr 12, 2023
Merged

Use set_verbosity abstraction instead of set #15470

merged 1 commit into from
Apr 12, 2023

Conversation

jack-w-shaw
Copy link
Member

Checklist

  • Code style: imports ordered, good names, simple structure, etc
  • [ ] Comments saying why design decisions were made
  • [ ] Go unit tests, with comments saying what you're testing
  • Integration tests, with comments saying what you're testing
  • [ ] doc.go added or updated in changed packages

QA steps

./main.sh -v -c aws -p aws -R eu-west-2 manual test_deploy_manual

@jack-w-shaw
Copy link
Member Author

/merge

@jujubot jujubot merged commit f869d3f into juju:2.9 Apr 12, 2023
@jack-w-shaw jack-w-shaw deleted the JUJU-3486_fix_verbosity branch April 12, 2023 12:55
@hmlanigan hmlanigan mentioned this pull request Apr 13, 2023
Merged
jujubot added a commit that referenced this pull request Apr 13, 2023
@jujubot
Merge pull request #15475 from hmlanigan/merge-to-3.0
37e2743 
#15475

- #15473 from jack-w-shaw/JUJU-3486_improve_logging
- #15472 from hpidcock/no-prompt-password
- #15470 from jack-w-shaw/JUJU-3486_fix_verbosity
- #15465 from barrettj12/bundle-arm


Conflicts:
* cmd/juju/user/change_password_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimonRichardson SimonRichardson SimonRichardson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@jack-w-shaw @SimonRichardson @jujubot