Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for no-prompt to login/change-user-password. #15472

Merged
merged 1 commit into from
Apr 13, 2023
Merged

Add support for no-prompt to login/change-user-password. #15472

merged 1 commit into from
Apr 13, 2023

Conversation

hpidcock
Copy link
Member

To make scripting easier for login and change-user-password, this introduces
a --no-prompt parameter to these commands. login also has a --trust for
trusting the controller's CA certificate when combined with --no-prompt.

With --no-prompt only the password can be read from stdin (newline expected), nothing else can be
read from stdin.

QA steps

  • ./main.sh -v -s '"test_user_manage"' user test_user_login_password
  • Also check you can still use the interactive flow.

Documentation changes

Command documentation needs to be regenerated.

Bug reference

N/A

@hpidcock hpidcock requested review from anvial and ycliuhw April 13, 2023 01:44
ycliuhw
ycliuhw approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@ycliuhw ycliuhw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ty!

@hpidcock hpidcock added the 2.9 label Apr 13, 2023
anvial
anvial approved these changes Apr 13, 2023
View reviewed changes
Copy link
Member

@anvial anvial left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx, it's a nice approach for all our interactive commands.

@hpidcock
Copy link
Member Author

/merge

1 similar comment
@hpidcock
Copy link
Member Author

/merge

@jujubot jujubot merged commit 9e65818 into juju:2.9 Apr 13, 2023
@hmlanigan hmlanigan mentioned this pull request Apr 13, 2023
Merged
jujubot added a commit that referenced this pull request Apr 13, 2023
@jujubot
Merge pull request #15475 from hmlanigan/merge-to-3.0
37e2743 
#15475

- #15473 from jack-w-shaw/JUJU-3486_improve_logging
- #15472 from hpidcock/no-prompt-password
- #15470 from jack-w-shaw/JUJU-3486_fix_verbosity
- #15465 from barrettj12/bundle-arm


Conflicts:
* cmd/juju/user/change_password_test.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anvial anvial anvial approved these changes

@ycliuhw ycliuhw ycliuhw approved these changes

Assignees
No one assigned
Labels
2.9
Projects
None yet
Milestone
No milestone
4 participants
@hpidcock @anvial @ycliuhw @jujubot