Merge to 3.0 #15475
Merged
Merge to 3.0 #15475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juju#15465 juju#15453 and juju#15460 tried to fix the deploy bundles tests, without success. Unfortunately, the `tiny-bash` charm doesn't support arm64, so we'll switch to the `juju-qa-test` charm which does. ## QA steps Check the bundles tests now pass. ```sh cd tests ./main.sh -v \n -s '"test_cmr_bundles_export_overlay,test_deploy_charms,test_deploy_default_series,test_deploy_os,test_deploy_revision,run_deploy_lxd_profile_bundle_openstack,run_deploy_lxd_profile_bundle"' \n deploy test_deploy_bundles ``` ## TODO - [x] Test on amd64 - [x] Test on arm64
juju#15470 ## Checklist - [x] Code style: imports ordered, good names, simple structure, etc - ~[ ] Comments saying why design decisions were made~ - ~[ ] Go unit tests, with comments saying what you're testing~ - [x] [Integration tests](https://github.com/juju/juju/tree/develop/tests), with comments saying what you're testing - ~[ ] [doc.go](https://discourse.charmhub.io/t/readme-in-packages/451) added or updated in changed packages~ ## QA steps ```sh ./main.sh -v -c aws -p aws -R eu-west-2 manual test_deploy_manual ```
juju#15472 To make scripting easier for `login` and `change-user-password`, this introduces a `--no-prompt` parameter to these commands. `login` also has a `--trust` for trusting the controller's CA certificate when combined with `--no-prompt`. With `--no-prompt` only the password can be read from stdin (newline expected), nothing else can be read from stdin. ## QA steps - `./main.sh -v -s '"test_user_manage"' user test_user_login_password` - Also check you can still use the interactive flow. ## Documentation changes Command documentation needs to be regenerated. ## Bug reference N/A
The primary purpose of this is to debug some errors we're seeing. However, this test could do with some logging here anyway
juju#15473 The primary purpose of this is to debug some errors we're seeing. However, this test could do with some logging here anyway ## Checklist - [x] Code style: imports ordered, good names, simple structure, etc - [x] Comments saying why design decisions were made - ~[ ] Go unit tests, with comments saying what you're testing~ - [x] [Integration tests](https://github.com/juju/juju/tree/develop/tests), with comments saying what you're testing - ~[ ] [doc.go](https://discourse.charmhub.io/t/readme-in-packages/451) added or updated in changed packages~ ## QA steps ```sh ./main.sh -v -c aws -R us-east-1 spaces_ec2 ```
|
/merge |
1 similar comment
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
juju-qa-testin bundle tests #15465 from barrettj12/bundle-armConflicts: