Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUJU-3488] Rename expose ec2 to firewall #15499

Merged

Conversation

jack-w-shaw
Copy link
Member

@jack-w-shaw jack-w-shaw commented Apr 18, 2023

In future versions more firewall related tests have be added

Change the name here to keep the suite names consistent

Checklist

  • [ ] Code style: imports ordered, good names, simple structure, etc
  • [ ] Comments saying why design decisions were made
  • [ ] Go unit tests, with comments saying what you're testing
  • Integration tests, with comments saying what you're testing
  • [ ] doc.go added or updated in changed packages

QA steps

./main.sh -v -c aws -p ec2 firewall

In future versions more firewall related tests will be added
@jack-w-shaw jack-w-shaw force-pushed the JUJU-3488_rename_expose_ec2_to_firewall branch from 2366674 to 3c1f901 Compare April 18, 2023 12:35
Copy link
Member

@nvinuesa nvinuesa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jack-w-shaw
Copy link
Member Author

/merge

1 similar comment
@jack-w-shaw
Copy link
Member Author

/merge

@jujubot jujubot merged commit a6cf482 into juju:2.9 Apr 18, 2023
5 checks passed
@jack-w-shaw jack-w-shaw deleted the JUJU-3488_rename_expose_ec2_to_firewall branch April 18, 2023 15:46
@jack-w-shaw jack-w-shaw mentioned this pull request Apr 19, 2023
jujubot added a commit that referenced this pull request Apr 20, 2023
#15506

Merges:
- #15487
- #15490
- #15492
- #15499
- #15497

Conflicts solved trivially:
- provider/maas/environprovider.go
- tests/suites/spaces_ec2/util.sh
@barrettj12 barrettj12 mentioned this pull request May 9, 2023
jujubot added a commit that referenced this pull request May 9, 2023
@barrettj12 barrettj12 mentioned this pull request May 10, 2023
jujubot added a commit that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants