Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JUJU-3584] Enable updating/setting owner labels by using secret-get #15537

Merged
merged 1 commit into from
Apr 27, 2023

Conversation

ycliuhw
Copy link
Member

@ycliuhw ycliuhw commented Apr 27, 2023

This PR implements updating/setting owner labels by using secret-get for:

  • owner units;
  • leader unit for application owned secrets;

Checklist

  • Code style: imports ordered, good names, simple structure, etc
  • Comments saying why design decisions were made
  • Go unit tests, with comments saying what you're testing
  • Integration tests, with comments saying what you're testing
  • doc.go added or updated in changed packages

QA steps

juju exec --unit snappass-test/0 'secret-add ownedby=snappass-test'
secret:ch52creffbas7aip1bjg

juju exec --unit snappass-test/0 'secret-add ownedby=snappass-test/0 --owner unit'
secret:ch52csmffbas7aip1bk0

juju exec --unit snappass-test/0 -- secret-get ch52creffbas7aip1bjg --label=snappass-test
ownedby: snappass-test

juju exec --unit snappass-test/0 -- secret-get --label=snappass-test
ownedby: snappass-test

juju exec --unit snappass-test/1 -- secret-get --label=snappass-test
ownedby: snappass-test

juju exec --unit snappass-test/0 -- secret-get ch52csmffbas7aip1bk0 --label=snappass-test/0
ownedby: snappass-test/0

juju exec --unit snappass-test/0 -- secret-get --label=snappass-test/0
ownedby: snappass-test/0

Documentation changes

No

Bug reference

https://bugs.launchpad.net/juju/+bug/2017042

@ycliuhw ycliuhw changed the title Enable updating/setting owner labels by using secret-get with URI and… Enable updating/setting owner labels by using secret-get Apr 27, 2023
@ycliuhw ycliuhw changed the title Enable updating/setting owner labels by using secret-get [JUJU-3584] Enable updating/setting owner labels by using secret-get Apr 27, 2023
@ycliuhw ycliuhw requested a review from wallyworld April 27, 2023 07:57
@ycliuhw
Copy link
Member Author

ycliuhw commented Apr 27, 2023

/merge

@jujubot jujubot merged commit 8c71c64 into juju:3.1 Apr 27, 2023
@ycliuhw ycliuhw mentioned this pull request May 5, 2023
jujubot added a commit that referenced this pull request May 5, 2023
#15558

Merge branch '3.1' into merge-3.1-20230505

- #15554
- #15555
- #15553
- #15552
- #15549
- #15538
- #15541
- #15537
- #15530

```
# Conflicts:
# .github/workflows/client-tests.yml
# apiserver/facades/agent/secretsmanager/secrets.go
# tests/suites/secrets_iaas/task.sh
```
@barrettj12 barrettj12 mentioned this pull request May 9, 2023
jujubot added a commit that referenced this pull request May 9, 2023
@barrettj12 barrettj12 mentioned this pull request May 10, 2023
jujubot added a commit that referenced this pull request May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants