Don't fail when when sshing netplan apply #15524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sometimes when we netplan apply over ssh, the session is terminated which leads to a false positive test result If the ssh command returns non-zzero error code, ignore it and continue. If it's a legitimate failure, we will fail later down the line anyway
|
/merge |
Merged
jujubot
added a commit
that referenced
this pull request
May 9, 2023
#15561 Merges the following patches: - #15558 - #15554 - #15555 - #15553 - #15552 - #15549 - #15538 - #15541 - #15534 - #15537 - #15535 - #15533 - #15529 - #15530 - #15522 - #15527 - #15523 - #15514 - #15524 - #15515 - #15520 - #15518 - #15510 - #15506 - #15500 - #15508 - #15497 - #15499 - #15492 - #15490 - #15487 ### Conflicts None.
Merged
jujubot
added a commit
that referenced
this pull request
May 10, 2023
#15565 Merges the following patches: - #15561 - #15558 - #15554 - #15555 - #15553 - #15552 - #15549 - #15538 - #15541 - #15534 - #15537 - #15535 - #15533 - #15529 - #15530 - #15522 - #15527 - #15523 - #15514 - #15524 - #15515 - #15520 - #15518 - #15510 - #15506 - #15500 - #15508 - #15497 - #15499 - #15492 - #15490 - #15487 ### Conflicts None.
3 tasks
jujubot
added a commit
that referenced
this pull request
May 22, 2023
…ec2_fix #15625 Backports #15524 and #15595 Sometimes when we netplan apply over ssh, the session is terminated which leads to a false positive test result If the ssh command returns non-zero error code, ignore it and continue. If it's a legitimate failure, we will fail later down the line anyway Also On spaces_ec2 tests, we first add a new nic for the current juju machine, then we get it's ID from ip link and then we patch the netplan config with this new NIC id and restart the machine. This causes the test to fail sometimes because we get the NIC id before it's UP and not shown in ip link. ## Checklist - [x] Code style: imports ordered, good names, simple structure, etc - [ ] Comments saying why design decisions were made - ~[ ] Go unit tests, with comments saying what you're testing~ - [x] [Integration tests](https://github.com/juju/juju/tree/develop/tests), with comments saying what you're testing - ~[ ] [doc.go](https://discourse.charmhub.io/t/readme-in-packages/451) added or updated in changed packages~ ## QA steps ```sh ./main.sh -v -c aws -R eu-west-2 spaces_ec2 ```
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sometimes when we netplan apply over ssh, the session is terminated which leads to a false positive test result
If the ssh command returns non-zero error code, ignore it and continue. If it's a legitimate failure, we will fail later down the line anyway
Checklist
[ ] Go unit tests, with comments saying what you're testing[ ] doc.go added or updated in changed packagesQA steps