Drop double notification on caasapplicationworker in TestWorker #15879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hpidcock
force-pushed
the
fix-caasapplicationworker-tests
branch
from
30ddfe0
to
de17fde
Compare
barrettj12
approved these changes
Jul 9, 2023
hpidcock
force-pushed
the
fix-caasapplicationworker-tests
branch
from
de17fde
to
f9161dd
Compare
jujubot
added a commit
that referenced
this pull request
Jul 10, 2023
…ts-2 #15880 Fixes race condition on buffered channel send sometimes notifying twice. Similar to #15879 ## QA steps - install golang.org/x/tools/cmd/stress@latest - `cd worker/caasapplicationprovisioner` - `go test -c -race` - `stress ./caasapplicationprovisioner.test` ## Documentation changes N/A ## Bug reference https://jenkins.juju.canonical.com/job/github-make-check-juju/7644/consoleText
|
/merge |
Merged
Merged
Merged
Merged
jujubot
added a commit
that referenced
this pull request
Jul 11, 2023
#15896 Forward ports: - #15845 - #15725 - #15852 - #15854 - #15849 - #15855 - #15857 - #15861 - #15862 - #15860 - #15864 - #15825 - #15866 - #15863 - #15870 - #15871 - #15872 - #15873 - #15874 - #15876 - #15875 - #15881 - #15727 - #15883 - #15884 - #15880 - #15879 - #15886 - #15887 - #15877 - #15888 - #15893 - #15894 Conflicts: - cmd/juju/ssh/debugcode_test.go - cmd/juju/ssh/debughooks_test.go - cmd/juju/ssh/scp_unix_test.go - cmd/juju/ssh/ssh_machine.go - cmd/juju/ssh/ssh_machine_test.go - cmd/juju/ssh/ssh_unix_test.go - worker/dbaccessor/worker.go - caas/kubernetes/provider/k8s_test.go - caas/kubernetes/provider/operator_test.go - caas/kubernetes/provider/package_test.go - caas/kubernetes/provider/rbac.go - cmd/juju/application/deployer/bundlehandler.go - cmd/juju/application/deployer/bundlehandler_test.go - cmd/jujud/agent/model/manifolds.go - core/bundle/changes/changes.go - worker/caasapplicationprovisioner/application.go - worker/caasapplicationprovisioner/application_test.go - worker/caasapplicationprovisioner/mock_test.go
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes race condition on buffered channel send sometimes notifying twice.
QA steps
cd worker/caasapplicationprovisionergo test -c -racestress ./caasapplicationprovisioner.testDocumentation changes
N/A
Bug reference
https://jenkins.juju.canonical.com/job/github-make-check-juju/7644/consoleText