Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add yosemite to macOSXSeries #966

Merged
merged 2 commits into from
Nov 20, 2014
Merged

add yosemite to macOSXSeries #966

merged 2 commits into from
Nov 20, 2014

Conversation

jrwren
Copy link
Contributor

@jrwren jrwren commented Oct 26, 2014

No description provided.

@axw
Copy link
Contributor

axw commented Oct 27, 2014

LGTM. I don't suppose you're aware of a command we can use to get the OS X codename, rather than mapping like this?

@jrwren
Copy link
Contributor Author

jrwren commented Oct 27, 2014

@axw I know of no such command.

@fwereade
Copy link
Contributor

fwereade commented Nov 3, 2014

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Nov 3, 2014

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Nov 3, 2014

Build failed: Does not match ['fixes-1388073', 'fixes-1388493']
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/1155

@fwereade
Copy link
Contributor

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Nov 14, 2014

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Nov 14, 2014

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/1315

@axw
Copy link
Contributor

axw commented Nov 17, 2014

Looks like an infrastructure issue.

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Nov 17, 2014

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Nov 17, 2014

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/1327

@axw
Copy link
Contributor

axw commented Nov 17, 2014

@jrwren Can you please update TestMacOSXSeries in osversion_test.go? The version 14 line needs to be changed, and a new one added for 15.

@aznashwan aznashwan mentioned this pull request Nov 19, 2014
Closed
@AdamIsrael
Copy link
Contributor

@awx I've updated TestMacOSXSeries per your comment.

@axw
Copy link
Contributor

axw commented Nov 20, 2014

@AdamIsrael Thanks. LGTM.

@axw
Copy link
Contributor

axw commented Nov 20, 2014

$$merge$$

@jujubot
Copy link
Collaborator

jujubot commented Nov 20, 2014

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

@jujubot
Copy link
Collaborator

jujubot commented Nov 20, 2014

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/1374

@axw
Copy link
Contributor

axw commented Nov 20, 2014

$$merge$$

On Thu, Nov 20, 2014 at 10:33 AM, Juju bot notifications@github.com wrote:

Build failed: Tests failed
build url: http://juju-ci.vapour.ws:8080/job/github-merge-juju/1374

—
Reply to this email directly or view it on GitHub
#966 (comment).

@jujubot
Copy link
Collaborator

jujubot commented Nov 20, 2014

Status: merge request accepted. Url: http://juju-ci.vapour.ws:8080/job/github-merge-juju

jujubot added a commit that referenced this pull request Nov 20, 2014
@jujubot
Merge pull request #966 from jrwren/master
724571c 
add yosemite to macOSXSeries
@jujubot jujubot merged commit 724571c into juju:master Nov 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jrwren @axw @fwereade @jujubot @AdamIsrael