Add examples directory and a simple Makefile for possible CI inclusion #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QA
|
| .PHONY: deps | ||
| deps: | ||
| $(GOPATH)/bin/godeps -u dependencies.tsv | ||
|
|
|
👍 with suggestions. QA was good. Thanks! |
|
|
||
| # Start of GOPATH-dependent targets. Some targets only make sense - | ||
| # and will only work - when this tree is found on the GOPATH. | ||
| ifeq ($(CURDIR),$(PROJECT_DIR)) |
There was a problem hiding this comment.
@mitechie cribbed from juju/charmstore
|
👍 ty for the update with one comment. |
Flesh out make targets, update readme with command. Extra whitespace removed Add help to .PHONY Flesh out README to be more copy-pastable
|
Thanks for the reviews! |
makyo
added a commit
that referenced
this pull request
Nov 13, 2014
Add examples directory and a simple Makefile for possible CI inclusion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.