lp1613839 - Add implicit int and uint to float64 conversion #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameinel
reviewed
Dec 9, 2018
|
I landed this, You'll probably want to submit a follow up PR against juju/juju that updates the dependency to the new commit (64a6158) |
jujubot
added a commit
to juju/juju
that referenced
this pull request
Dec 13, 2018
#9567 ## Description of change Update juju/schema with fix for [#1613839](https://bugs.launchpad.net/juju/+bug/1613839) See: juju/schema#17 ## QA steps QA tests are embedded within juju/schema. I have also retested as described in [bug comment](https://bugs.launchpad.net/juju/+bug/1613839/comments/5) ## Bug reference [lp1613839](https://bugs.launchpad.net/juju/+bug/1613839)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves lp1613839.
The float checker only accepts float values, and, in contradiction to other checkers, does not do any simple conversions. This leads to a problem where any number specified without decimal part (eg 1) or with 0 decimal part (1.0) cannot be used in YAML files as it causes juju error.
This is a simple patch which allows int and uint conversions to float64 within float checker.