-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First cut. #1
First cut. #1
Conversation
Nice first cut ! Just a few points : QA : tried the different make, all working great, except make coverage which is not present. |
Done.
bin, include, and local have been added. doc/theblues.rst isn't a generated file, so I'm unsure why you think it should be added?
Yeah, I can add that; we actually need to come up with a better solution, b/c that make this difficult to easily pip install.
We shall, but I know not what. Didn't think we needed to sort that for this. |
This is strange make docs does modify doc/theblues.rst. |
So, it was adding the submodule stuff, which should be added; I've checked in those changes along with some other doc changes. |
History | ||
------- | ||
|
||
0.0.1 (2015-01-01) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why Jan 1?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Autogenerated by cookiecutter; I just didn't catch it.
Have we talked about licensing? Seems it would just be GPLv3 unless there is something unique. We will need a download-cache, right? Be sure to test it with no network. :( I didn't do any QA. I'd like to re-review after changes, though all but the pesky naming question are straight-forward. |
We will not have a downloadcache; this will go in the download cache for things that need it. |
@bac I think I caught all your points; let me know if I missed anything. @fabricematrat thanks for verifying the makefile and noting the docs oddities--I think we're all squared away there for now as well (though the docs need quite a lot of work. :p) |
👍 thanks for the changes! |
👍 Looks very nice. |
First cut of theblues library, very pre-alpha.
No description provided.