Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First cut. #1

Merged
merged 1 commit into from
Mar 20, 2015
Merged

First cut. #1

merged 1 commit into from
Mar 20, 2015

Conversation

jcsackett
Copy link
Contributor

No description provided.

@fabricematrat
Copy link
Contributor

Nice first cut !

Just a few points :
Code :
There is a .swp that need to be removed
in the .gitignore, needs to add: bin, include, local, doc/theblues.rst
I think the Makefile needs a sys-deps for things like libsodium13 libmacaroons0 python-macaroons.
Shall we have a licence file ?

QA : tried the different make, all working great, except make coverage which is not present.
We need a download-cache I suppose also but might come later.

@jcsackett
Copy link
Contributor Author

There is a .swp that need to be removed

Done.

in the .gitignore, needs to add: bin, include, local, doc/theblues.rst

bin, include, and local have been added. doc/theblues.rst isn't a generated file, so I'm unsure why you think it should be added?

I think the Makefile needs a sys-deps for things like libsodium13 libmacaroons0 python-macaroons.

Yeah, I can add that; we actually need to come up with a better solution, b/c that make this difficult to easily pip install.

Shall we have a licence file ?

We shall, but I know not what. Didn't think we needed to sort that for this.

@fabricematrat
Copy link
Contributor

This is strange make docs does modify doc/theblues.rst.

@jcsackett
Copy link
Contributor Author

So, it was adding the submodule stuff, which should be added; I've checked in those changes along with some other doc changes.

History
-------

0.0.1 (2015-01-01)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why Jan 1?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Autogenerated by cookiecutter; I just didn't catch it.

@bac
Copy link

bac commented Mar 19, 2015

Have we talked about licensing? Seems it would just be GPLv3 unless there is something unique.

We will need a download-cache, right? Be sure to test it with no network. :(

I didn't do any QA.

I'd like to re-review after changes, though all but the pesky naming question are straight-forward.

@jcsackett
Copy link
Contributor Author

We will not have a downloadcache; this will go in the download cache for things that need it.

@jcsackett
Copy link
Contributor Author

@bac I think I caught all your points; let me know if I missed anything.

@fabricematrat thanks for verifying the makefile and noting the docs oddities--I think we're all squared away there for now as well (though the docs need quite a lot of work. :p)

@bac
Copy link

bac commented Mar 19, 2015

👍 thanks for the changes!

@fabricematrat
Copy link
Contributor

👍 Looks very nice.

jcsackett added a commit that referenced this pull request Mar 20, 2015
First cut of theblues library, very pre-alpha.
@jcsackett jcsackett merged commit 4138f4b into juju:develop Mar 20, 2015
jujugui pushed a commit that referenced this pull request Nov 19, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants