Add engine configuration options for exponential backoff #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wallyworld
approved these changes
Oct 23, 2018
dependency/engine.go
Outdated
| @@ -80,6 +88,14 @@ func (config *EngineConfig) Validate() error { | |||
| if config.BounceDelay < 0 { | |||
| return errors.New("BounceDelay is negative") | |||
| } | |||
| if config.BackoffFactor != 0 { | |||
There was a problem hiding this comment.
why not consolidate into one line?
babbageclunk
approved these changes
Oct 23, 2018
dependency/engine.go
Outdated
| @@ -80,6 +88,14 @@ func (config *EngineConfig) Validate() error { | |||
| if config.BounceDelay < 0 { | |||
| return errors.New("BounceDelay is negative") | |||
| } | |||
| if config.BackoffFactor != 0 { | |||
| if config.BackoffFactor < 1 { | |||
There was a problem hiding this comment.
Might be nicer as config.BackoffFactor != 0 && config.BackoffFactor < 1?
dependency/engine.go
Outdated
| @@ -368,7 +389,17 @@ func (engine *Engine) requestStart(name string, delay time.Duration) { | |||
| // Always fuzz the delay a bit to help randomise the order of workers starting, | |||
| // which should make bugs more obvious | |||
| if delay > time.Duration(0) { | |||
| delay += time.Duration(rand.Int31n(60)) * time.Millisecond | |||
| if engine.config.BackoffFactor > 0 { | |||
| for i := 1; i < info.startAttempts; i++ { | |||
| delay = engine.config.MaxDelay | ||
| } | ||
| } | ||
| // Fuzz to ±10% of final duration. |
There was a problem hiding this comment.
Nice use of ±! (I had to copy it because I couldn't be bothered to work out how to type one.)
There was a problem hiding this comment.
@jameinel made me use it.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add EngineConfig options to allow exponential backoff when determining worker restart delays.
Also tweaks some of the logging to make the default debug output for a restarting engine somewhat quieter.