feat(openapi): Update spec to include role=function + render_templates #276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Singh Tomer <diwank.singh@gmail.com>
Signed-off-by: Diwank Singh Tomer <diwank.singh@gmail.com>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
👍 Looks good to me!
- Reviewed the entire pull request up to 76766e9
- Looked at
5409lines of code in19files - Took 2 minutes and 45 seconds to review
More info
- Skipped
2files when reviewing. - Skipped posting
4additional comments because they didn't meet confidence threshold of50%.
1. /sdks/python/julep/api/types/chat_ml_message_role.py:18:
- Assessed confidence :
0% - Comment:
The new 'function' role has been added correctly to the ChatMlMessageRole enum. - Reasoning:
The new 'function' role has been added to the ChatMlMessageRole enum in the Python SDK and the TypeScript SDK. This change is consistent across the codebase and there doesn't seem to be any issues with it.
2. /sdks/ts/src/api/models/Session.ts:41:
- Assessed confidence :
0% - Comment:
The 'render_templates' field has been added correctly to the Session model. - Reasoning:
The 'render_templates' field has been added to the Session model in the TypeScript SDK. This change is consistent across the codebase and there doesn't seem to be any issues with it.
3. /sdks/ts/src/api/schemas/$CreateSessionRequest.ts:29:
- Assessed confidence :
0% - Comment:
The 'render_templates' field has been added correctly to the $CreateSessionRequest schema. - Reasoning:
The 'render_templates' field has been added to the $CreateSessionRequest schema in the TypeScript SDK. This change is consistent across the codebase and there doesn't seem to be any issues with it.
4. /sdks/ts/src/api/schemas/$Session.ts:49:
- Assessed confidence :
0% - Comment:
The 'render_templates' field has been added correctly to the $Session schema. - Reasoning:
The 'render_templates' field has been added to the $Session schema in the TypeScript SDK. This change is consistent across the codebase and there doesn't seem to be any issues with it.
Workflow ID: wflow_EKP4pk9hy0TNIswu
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
Signed-off-by: Diwank Singh Tomer <diwank.singh@gmail.com>
There was a problem hiding this comment.
👍 Looks good to me!
- Performed an incremental review on f577807
- Looked at
35lines of code in2files - Took 3 minutes and 8 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
2additional comments because they didn't meet confidence threshold of50%.
1. sdks/python/julep/api/types/chat_input_data_tool_choice.py:6:
- Assessed confidence :
50% - Comment:
The import statement for 'NamedToolChoiceFunction' has been removed. Please confirm if this is intentional and 'NamedToolChoiceFunction' is no longer used. - Reasoning:
The import statement for 'NamedToolChoiceFunction' has been removed, but it's not clear if this is intentional or an oversight. If 'NamedToolChoiceFunction' is no longer used, this change is fine. However, if it's still needed, this could cause a bug. I'll need to check the rest of the codebase to see if 'NamedToolChoiceFunction' is used elsewhere.
2. sdks/python/julep/api/client.py:832:
- Assessed confidence :
50% - Comment:
The 'preset' field has been updated to include a type ignore comment. Please confirm if this is intentional and there are no potential issues with the 'preset' field being of a different type than expected. - Reasoning:
The 'preset' field in the 'chat' function of 'client.py' has been updated to include a type ignore comment. This is likely due to a type hinting issue where the 'preset' field is expected to be of a certain type, but the actual value may not always match this type. This is a common issue in Python, especially when dealing with optional fields or fields that can have multiple types. The type ignore comment is a way to tell the type checker to ignore this field, effectively bypassing the type check. This is not necessarily a bug, but it's worth noting as it could potentially lead to runtime errors if the 'preset' field is not of the expected type. I'll need to check the rest of the codebase to see if there are any potential issues with the 'preset' field.
Workflow ID: wflow_79GBQnHMCrmuvcc2
Not what you expected? You can customize the content of the reviews using rules. Learn more here.
This was referenced Apr 26, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR introduces a new feature to render system and assistant message content as Jinja templates, adds a new 'function' role in the ChatMlMessageRole model, updates various files in the Python and TypeScript SDKs, generates documentation for the TypeScript SDK, and includes several fixes.
Key points:
Generated with ❤️ by ellipsis.dev