use VALID_MODELS to support JULEP_MODELS #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested.
- Reviewed the entire pull request up to 966d0ec
- Looked at
14lines of code in1files - Took 54 seconds to review
More info
- Skipped
0files when reviewing. - Skipped posting
0additional comments because they didn't meet confidence threshold of50%.
Workflow ID: wflow_uXXKJgZXSrUT67VJ
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with review rules, user-specific overrides, quiet mode, and more. See docs.
| @@ -111,7 +111,7 @@ def validate_configuration(model: str): | |||
| """ | |||
| if model not in ALL_AVAILABLE_MODELS: | |||
| raise AgentModelNotValid(model, ALL_AVAILABLE_MODELS) | |||
| elif model not in get_valid_models(): | |||
| elif model not in VALID_MODELS: | |||
There was a problem hiding this comment.
Replacing get_valid_models() with VALID_MODELS might introduce issues if VALID_MODELS does not dynamically update as get_valid_models() might. This could lead to using outdated or incorrect model validations. Consider reverting this change or ensuring VALID_MODELS updates dynamically as needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Refactors
validate_configurationto useVALID_MODELSdirectly for model validation, includingJULEP_MODELS.Key points:
validate_configurationin/agents-api/agents_api/model_registry.pyto useVALID_MODELSdirectly.get_valid_models(), simplifying the validation logic.JULEP_MODELSare included in the validation process.Generated with ❤️ by ellipsis.dev