Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

session.chat working without specifying user #338

Merged
merged 2 commits into from
May 27, 2024
Merged

Conversation

alt-glitch
Copy link
Contributor

@alt-glitch alt-glitch commented May 25, 2024

  • also added a volume for embedding services to prevent unnecessary redownloads

🚀 This description was created by Ellipsis for commit 8ddc6a0

Summary:

Updated session management to handle optional user data and optimized embedding services with persistent volume caching.

Key points:

  • Made user_id optional in SessionData class and adjusted related queries in proc_mem_context.py and session_data.py.
  • Added persistent volume for embedding services in docker-compose.yml to optimize data handling.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to 8ddc6a0 in 1 minute and 4 seconds

More details
  • Looked at 167 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/docker-compose.yml:67
  • Draft comment:
    The addition of a volume to cache HuggingFace models is a good practice to reduce unnecessary downloads and speed up container startup times. The implementation here is correct and follows Docker best practices.
  • Reason this comment was not posted:
    Confidence changes required: 0%
    The PR description mentions adding a volume for embedding services to prevent unnecessary redownloads. This change is reflected in the docker-compose.yml file where a volume is mounted to the text-embedding services. This is a good practice as it allows the container to reuse downloaded models, reducing network traffic and speeding up startup times. The implementation seems correct as it uses the standard Docker volume syntax and points to the HuggingFace cache directory.

Workflow ID: wflow_A2qTubuWoWINy5dY


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@creatorrr creatorrr enabled auto-merge (squash) May 27, 2024 00:30
Copy link
Contributor

@creatorrr creatorrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@creatorrr creatorrr merged commit 98c95fe into dev May 27, 2024
4 checks passed
@creatorrr creatorrr deleted the f/chat-without-user branch May 27, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants