Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs-text-embeddings-inference service to deploy/docker-compose.yml #339

Merged
merged 3 commits into from
May 27, 2024

Conversation

creatorrr
Copy link
Contributor

@creatorrr creatorrr commented May 27, 2024

Adds the docs-text-embeddings-inference service to deploy/docker-compose.yml as per the task requirements.

  • Service Addition: Introduces the docs-text-embeddings-inference service with its configuration, including environment variables (DTYPE, MODEL_ID), image source, ports, volumes, shared memory size, and deployment resources specifying GPU usage.
  • Configuration Consistency: Ensures that the new service's environment variables and deployment settings match those specified in the task, maintaining consistency with the existing services in the file.

For more details, open the Copilot Workspace session.


🚀 This description was created by Ellipsis for commit c0dfbce

Summary:

Adds a new service docs-text-embeddings-inference to deploy/docker-compose.yml, configured with specific environment variables, ports, and GPU resources, ensuring consistency with existing services.

Key points:

  • Adds docs-text-embeddings-inference service to deploy/docker-compose.yml
  • Configures service with environment variables (DTYPE, MODEL_ID), image, ports, volumes, shared memory, and GPU resources
  • Ensures consistency with existing services

Generated with ❤️ by ellipsis.dev

@creatorrr creatorrr requested a review from alt-glitch May 27, 2024 03:54
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to c0dfbce in 50 seconds

More details
  • Looked at 41 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. deploy/docker-compose.yml:66
  • Draft comment:
    Ensure that the port 8083 used by docs-text-embeddings-inference is not conflicting with other services in the docker-compose file. If it is, consider changing it to an unused port.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_QpAfmS89sFVSvJaT


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@alt-glitch alt-glitch merged commit f715997 into dev May 27, 2024
4 checks passed
@alt-glitch alt-glitch deleted the creatorrr/add-docs-service branch May 27, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants