Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support for Hermes-2-Theta-Llama-3-8B as default OSS model #424

Merged
merged 12 commits into from
Jul 4, 2024

Conversation

alt-glitch
Copy link
Contributor

@alt-glitch alt-glitch commented Jul 1, 2024

Closes #410
Closes #413
Closes #406


🚀 This description was created by Ellipsis for commit 5e17da9

Summary:

Updated default model to Hermes-2-Theta-Llama-3-8B and refactored related environment variables and model handling logic.

Key points:

  • Closes Remove llm-embedder dependency entirely #410
  • Closes Upgrade TEI to 1.3 #413
  • Closes Deprecate samantha-1-turbo based model-api and instead default to NousResearch/Hermes-2-Theta-Llama-3-8B #406
  • Updated .env.example to set MODEL_NAME to julep-ai/Hermes-2-Theta-Llama-3-8B and adjusted related environment variables.
  • Modified agents-api/agents_api/activities/embed_docs.py to use embedding_model_id instead of docs_embedding_model_id.
  • Updated agents-api/agents_api/activities/summarization.py to replace JULEP_MODELS with LOCAL_MODELS.
  • Refactored agents-api/agents_api/embed_models_registry.py to consolidate embedding service URLs and model IDs.
  • Adjusted agents-api/agents_api/env.py to remove docs_embedding_service_url and docs_embedding_model_id.
  • Renamed JULEP_MODELS to LOCAL_MODELS in agents-api/agents_api/model_registry.py and added new local models.
  • Added agents-api/agents_api/prompt_assets/sys_prompt.yml for system prompts.
  • Updated agents-api/agents_api/rec_sum/generate.py to use LOCAL_MODELS.
  • Modified agents-api/agents_api/routers/sessions/session.py to handle tool calls and update settings.
  • Updated agents-api/docker-compose.yml to remove docs-text-embeddings-inference service.
  • Simplified model-serving/Dockerfile and updated entrypoint.
  • Adjusted model-serving/docker-compose.yml to align with new environment variables.

Generated with ❤️ by ellipsis.dev

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Reviewed everything up to ce2bccf in 1 minute and 17 seconds

More details
  • Looked at 646 lines of code in 12 files
  • Skipped 1 files when reviewing.
  • Skipped posting 3 drafted comments based on config settings.
1. .env.example:16
  • Draft comment:
    The JWT_SHARED_KEY is set to an empty value, which could lead to security vulnerabilities. Ensure that this key is properly set in production environments to maintain the integrity and security of JWT tokens.
JWT_SHARED_KEY=your_secure_key_here
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.
2. .env.example:43
  • Draft comment:
    The OPENAI_API_KEY is set to an empty value, which might cause issues if the key is required for accessing OpenAI services. Ensure that this key is properly set in production environments to maintain functionality.
OPENAI_API_KEY=your_openai_api_key_here
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.
3. model-serving/Dockerfile:5
  • Draft comment:
    The MODEL_NAME environment variable is set to julep-ai/samantha-1-turbo, which might not reflect the intended default model Hermes-2-Theta-Llama-3-8B as per the PR title. Update this to ensure consistency across the deployment.
ENV MODEL_NAME julep-ai/Hermes-2-Theta-Llama-3-8B
  • Reason this comment was not posted:
    Confidence of 20% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_accoWmUHIYzeF3u3


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

.env.example Outdated Show resolved Hide resolved
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❌ Changes requested. Incremental review on debe630 in 54 seconds

More details
  • Looked at 199 lines of code in 4 files
  • Skipped 0 files when reviewing.
  • Skipped posting 0 drafted comments based on config settings.

Workflow ID: wflow_RKpv6Xwdh1HM5FWd


Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

model-serving/Dockerfile Show resolved Hide resolved
@creatorrr
Copy link
Contributor

creatorrr commented Jul 1, 2024

lgtm, some todos:

  • upgrade to TEI 1.3 (should work as is)
  • review and resolve ellipsis comments
  • please test this end to end

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on e7ab98f in 47 seconds

More details
  • Looked at 170 lines of code in 6 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/docker-compose.yml:64
  • Draft comment:
    The PR description states that the docs-text-embeddings-inference service is removed, but the Dockerfile still references the text-embeddings-inference service. Please confirm if this service is intended to be removed or if it should remain.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_lHjGznKHEa5p4NSC


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Diwank Tomer and others added 2 commits July 3, 2024 18:16
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Incremental review on 5e17da9 in 47 seconds

More details
  • Looked at 23 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. agents-api/agents_api/model_registry.py:216
  • Draft comment:
    The PR description mentions renaming JULEP_MODELS to LOCAL_MODELS, but the diff does not reflect this change. Please ensure that the renaming is correctly implemented throughout the codebase.
  • Reason this comment was not posted:
    Confidence of 0% on close inspection, compared to threshold of 50%.

Workflow ID: wflow_yZ99LHv667l7rVaM


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@alt-glitch
Copy link
Contributor Author

tested

@alt-glitch alt-glitch merged commit c9171a9 into dev Jul 4, 2024
9 checks passed
@alt-glitch alt-glitch deleted the f/local-llm-support branch July 4, 2024 04:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants