f/wait for input step #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Diwank Tomer <diwank@julep.ai>
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to fdcfe57 in 59 seconds
More details
- Looked at
3687lines of code in48files - Skipped
2files when reviewing. - Skipped posting
0drafted comments based on config settings.
Workflow ID: wflow_XhHeKxZQqGjjRyiL
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| from ..core.pydantic_utilities import deep_union_pydantic_dicts, pydantic_v1 | ||
|
|
||
|
|
||
| class TasksBaseWorkflowStep(pydantic_v1.BaseModel): |
There was a problem hiding this comment.
The TasksBaseWorkflowStep class should define a field for kind_ to specify the type of workflow step. This is crucial for proper type discrimination in polymorphic scenarios.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Added
WaitForInputSteptoagents-apiand updated SDKs; disabled all routes except tasks and agents.Key points:
WaitForInputSteptoagents-api.Tasks.pyto includeWaitForInputStepin various classes likeCreateTaskRequest,PatchTaskRequest, etc.TasksWaitForInputStepandTasksWaitForInputStepInfo.agents_api/web.py.WaitForInputStepin various files liketasks_create_task_request_main_item.py,tasks_patch_task_request_main_item.py, etc.WaitForInputStepin various models and schemas likeTasks_CreateTaskRequest,Tasks_PatchTaskRequest, etc.Generated with ❤️ by ellipsis.dev