-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Retrieve remote caches #204
Conversation
I think that probably will work for starters, but I think medium term we could:
|
We should now use this code to download: Pkg.PlatformEngines.download_verify_unpack("https://symbolcache.julia-vscode.org/store/v1/packages/A/AndExport_4484d908-372d-4f90-b90b-0ec97f005b8c/v1.0.1_ebc539a19124dd3f67087d50376adc010c577536.tar.gz", nothing, folderpath_where_you_want_the_extracted_file) That is also the current URL format. |
New format for the URLs for now:
|
I think ideally, yes, but we may run into issues trying to interogate where packages are installed locallly without activating the target environment. This will be needed when modifying the downloaded caches to point to the correct local paths. |
Another question: should we store cloud retrieved cache files and locally generated cache files in different locations, just so that we can later distinguish where they came from? I think in the end we probably want to look in three different locations always no matter what: 1) in a read-only folder in the extension itself (for caches that we ship out of the box), 2) in a location for cloud downloads, and 3) in a location for locally generated caches. |
I think we need an option to disable cloud downloads somewhere -- maybe just check an environment variable ( |
Do we want it as an ENV rather than just an argument passed to |
An argument is better, but needs to be piped through all the way from the |
Yeah that's slightly more annoying but seems the best way to me, unless there other good reasons not to |
Agreed that an argument is nicer :) Yes, more work, but I think there is also just value in handling all config the same way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't review carefully, but lets ship to insider and see whether it works.
A first draft of how this may look on the client side- thoughts?
Ship stdlib caches?