Add wildcarding for custom namespaces #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natefitzgerald
force-pushed
the
master
branch
from
a265491
to
fa154db
Compare
|
Pardon the delay, Admiral. This is now included in avrohugger 1.0.0-RC25 and sbt-avrohugger 2.0.0-RC25, thanks very much for the contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey this is my first PR to this repo. I'm using this package and our build.sbt file is getting really gross from all of the separate package renaming we have to do. I figured I'm probably not the only one.
I'm pretty confident this suits my needs well but I didn't know how much flexibility this feature needs. If you want the matching to be more robust we could use a real regex.
Feel free to rip me a new one if I did something wrong or you don't like the code stylistically.