Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use includeFilter and excludeFilter to specify what Avro files to use #25

Merged
merged 2 commits into from
Sep 22, 2016
Merged

Use includeFilter and excludeFilter to specify what Avro files to use #25

merged 2 commits into from
Sep 22, 2016

Conversation

mariussoutier
Copy link
Contributor

I came across a case where I had a couple of Avro schemas that I don't want to generate classes for, so I added the ability to exclude / include specific files. Per default all goes through.

By the way, did you remove sbt-scripted?

@julianpeeters
Copy link
Owner

Looking great. Nice use of sbt's existing FileFilter :) I'd merge this in, but since it's to master I want to make sure it's as well-tested as possible -- here meaning restoring the scripted tests, or at least setting a single scripted project up to test this new feature.

@mariussoutier
Copy link
Contributor Author

Damn I deleted the tests I wrote on the old version, but essentially I checked for existing and non-existing files when excluding certain AVDLs.

@julianpeeters
Copy link
Owner

Ok great

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants