Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add unit tests for useIsClient #161

Merged
merged 3 commits into from
May 30, 2022
Merged

test: add unit tests for useIsClient #161

merged 3 commits into from
May 30, 2022

Conversation

createdbymahmood
Copy link
Contributor

This small PR adds unit tests for useIsClient hook, but I'm not sure if they're enough, any ideas?

@createdbymahmood
test: add unit tests for useIsClient
28aa277 
add another test case

fix
@PabloLION
Copy link
Contributor

LGTM 👍

@juliencrn
Copy link
Owner

Hi @createdbymahmood, nice work, thank you!

I had errors testing locally, it was that SSR tests require react-dom instead of react-test-renderer, so I moved to.

Now it works perfectly, cool 😎

@juliencrn juliencrn merged commit d319433 into juliencrn:master May 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@createdbymahmood @PabloLION @juliencrn