Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve scroll lock issue on ios safari #509

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

jontewks
Copy link
Contributor

Resolves #508

Copy link

changeset-bot bot commented Feb 23, 2024

🦋 Changeset detected

Latest commit: e447a9a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
usehooks-ts Patch
www Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@juliencrn juliencrn self-requested a review February 23, 2024 00:12
Copy link
Owner

@juliencrn juliencrn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thank you 👍

@juliencrn juliencrn merged commit 823b62f into juliencrn:master Feb 23, 2024
2 checks passed
@jontewks jontewks deleted the jt/fix-use-scroll-lock branch February 23, 2024 01:56
@jontewks
Copy link
Contributor Author

Thanks for the quick check, and for fixing those tests I totally missed 😬

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] useScrollLock doesn't work in ios safari
2 participants